I don't quite understand. Is commenting sub-modules a required step? Pointing to a "please remove the commented block" document is not a good idea. The contents of a release MUST match the corresponding tag in SVN. The release manager signs the release to prove that.Now we have a situation when a file in the assembly differs from SVN and this is not good.
Secondly, people download source releases to build artifacts. They expect to unpack the distribution archive, read build instructions in README.txt and build. In our case "mvn install" should work out of the box without any tricks and hacks and modifications. Yegor 2011/12/26 Devin Han <[email protected]>: > Hi Yegor, > > Thank you for the vote. I think I need to explain this issue. > I commented all of the sub-modules, just for running the profile > "apache-release" and avoid to apply it on the sub modules. > We can point it out to the user in the document, such as: "please remove > the commented block, if you want to build this project by yourselves." Is > it OK? > > > 在 2011年12月26日 下午10:45，Yegor Kozlov <[email protected]>写道： > >> Davin, thank you for correcting all the issues, we are almost there. >> >> The binary assemblies look good. >> >> Unfortunately there is a problem with the source assemblies. I >> downloaded odftoolkit-0.5-incubating-src.tar.gz but could not build >> the project. All sub-modules are commented in the root pom.xml: >> >> <!-- >> <modules> >> <module>taglets</module> >> <module>generator</module> >> <module>xslt-runner</module> >> <module>xslt-runner-task</module> >> <module>odfdom</module> >> <module>validator</module> >> <module>simple</module> >> </modules> >> --> >> >> As result, Maven doesn't see the modules and can't build. No luck with >> building from odftoolkit-0.5-incubating-src.zip either. >> >> I guess it was a last minute change, because the pom in svn is correct: >> >> http://svn.apache.org/viewvc/incubator/odf/tags/odftoolkit-0.5-incubating/pom.xml?view=markup >> >> It is a blocker and I vote [-1] . >> >> >> Regards, >> Yegor >> >> 2011/12/24 Devin Han <[email protected]>: >> > Hi all, >> > >> > Merry Christmas！ There is a special gift ;) >> > Please vote on releasing the following candidate as Apache ODF Toolkit >> > (incubating) version 0.5. This will be the first incubator release for >> > ODF Toolkit in Apache. >> > >> > This release candidate fixes the following issues found in RC5: >> > (1) Reomve JUnit declaration from NOTICE & LICENSE files. >> > (2) Fix the "mvn clean" failed issue. >> > >> > The candidate for the ODF Toolkit 0.5-incubating release is available at: >> > >> > >> http://people.apache.org/~devinhan/odftoolkit-release/odftoolkit-0.5-incubating-rc6/ >> > >> > The release candidate is a zip archive of the sources in: >> > >> > >> https://svn.apache.org/repos/asf/incubator/odf/tags/odftoolkit-0.5-incubating/ >> > >> > The SHA1 checksum of the archive is >> > 44e16d8ee39fc0426f96aa7da9cd8eefccaf78e5. >> > The MD5 checksum of the archive is c12a87f0ca441f23d945a423e1d4127c. >> > >> > Besides source code, binary packages and javadoc packages are also listed >> > in： >> > >> http://people.apache.org/~devinhan/odftoolkit-release/odftoolkit-0.5-incubating-rc6/ >> > >> > All of the artifacts supply three package formats, tar.gz, tar.bz2 and >> zip. >> > >> > Keys: >> > http://www.apache.org/dist/incubator/odftoolkit/KEYS >> > >> > Please vote on releasing this package as Apache ODF Toolkit >> 0.5-incubating. >> > The vote is open for the next full week, until next Saturday, Dec 31rd >> 6pm, >> > because of the Christmas holiday, and passes if a majority of at least 3 >> +1 >> > IPMC votes are cast. >> > >> > [ ] +1 Release this package as Apache ODF Toolkit 0.5-incubating >> > [ ] -1 Do not release this package because... >> > >> > To learn more about Apache ODF Toolkit, please access: >> > http://incubator.apache.org/odftoolkit/. >> > >> > >> > @OOo-Dev, @POI-Dev, @Tika-Dev and @PDFBox-Dev, so sorry for the >> interrupt. >> > CC to you just wish to get your feedback, as your projects have more or >> > less interaction with ODFToolkit and we need more votes. >> > >> > -- >> > -Devin >> > > > > -- > -Devin
