Hi Dennis, hi all,
I have overseen your mail, but now after testing myself, I came to the
same conclusion.
As you stated before, if we add a new profile for JDK7 it works on all JDK.
The IDs are in this case arbitrary as the artifact is not being loaded
from the Maven repository, but is taken from the hard disk, using the
JAVA_HOME environment variable.
As the ID is arbitrary, I called them "prior-jdk7-tools.jar" and
"jdk7-tools.jar".
<profile>
<id>jdk7-tools.jar</id>
<activation>
<property>
<name>java.vendor</name>
<value>Oracle Corporation</value>
</property>
</activation>
<dependencies>
<dependency>
<groupId>com.sun</groupId>
<artifactId>tools</artifactId>
<version>1.7.0</version>
<scope>system</scope>
<systemPath>${java.home}/../lib/tools.jar</systemPath>
</dependency>
</dependencies>
</profile>
We might want to add the above to the pom.xml of the taglet subproject.
There should be an issue, but I could not find one. I have not started
to work on the Toolkit by now. But as soon I start, I will take care of
this, unless Devin have not integrated it already after his Dragon fiesta.
- Svante
On 07.01.2012 21:56, Dennis E. Hamilton wrote:
> Rob,
>
> I tried simply duplicating the <profile> element, once with each vendor, but
> I failed to pass go. Maven doesn't like duplicate profile names.
>
> So I changed the <profile> names. One has <id> "tools-Oracle.jar" and the
> other has <id> "tools-Sun.jar" (the second one, matching the original).
>
> I was able to duplicate my successful JDK 6u30 build.
>
> I was also able to obtain a successful JDK 7u2 build using the same POM.
>
> The log from the 7u2 clean install is shorter (1,146,287 bytes) than the one
> from 6u30 (1,163,669 bytes) and the 7u2 took 21 seconds less (though that
> could be caching as well as less writing).
>
> I haven't checked for details of the difference. It appears to be
> inconsequential. I will check later to see if there is a difference in tests
> that ran.
>
> - Dennis
>
> SUMMARY RESULTS (line breaks added for readability):
>
> CONSOLE SESSION
>
> * MyMVN.bat 0.00 ESTABLISH MAVEN CONSOLE-SESSION ENVIRONMENT
> ** MyMaven64.bat 0.02 64-BIT APACHE MAVEN PROJECT-OBJECT ENVIRONMENT
> *** MyJDK64.bat 0.04 orcmid's ASTRAENDO 64-BIT JDK ENVIRONMENT
> JDK C:\Program Files\Java\jdk1.7.0_02
> %myJavaClasses% path C:\Users\orcmid\Documents\MyProjects\java
> No %MAVEN_OPTS% for C:\Program Files\Apache\Maven\3.0.3
>
>
> C:\Users\orcmid\Downloads\odftoolkit-0.5-incubating>mvn --version
> Apache Maven 3.0.3 (r1075438; 2011-02-28 09:31:09-0800)
> Maven home: C:\Program Files\Apache\Maven\3.0.3
> Java version: 1.7.0_02, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_02\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> C:\Users\orcmid\Downloads\odftoolkit-0.5-incubating>
> mvn clean install >2012-01-07-1232-clean-7u2.log
> C:\Users\orcmid\Downloads\odftoolkit-0.5-incubating>exit
>
> END OF 2012-01-07-1232-clean-7u2.log FILE ("[INFO] " deleted):
>
> -----------------------------------------------------------------------
> Reactor Summary:
>
> Apache ODF Toolkit ................................ SUCCESS [1.029s]
> ODF Custom Javadoc Taglets ........................ SUCCESS [5.897s]
> XML Schema to Template Mapping Tool: Parent POM ... SUCCESS [0.031s]
> XML Schema to Template Mapping Tool: Library ...... SUCCESS [27.737s]
> XML Schema to Template Mapping Tool: Maven2 Plugin SUCCESS [2.777s]
> ODFDOM ............................................ SUCCESS [3:41.506s]
> ODF XSLT-Runner ................................... SUCCESS [0.998s]
> ODF XSLT-Runner Ant Task .......................... SUCCESS [0.624s]
> ODF Validator ..................................... SUCCESS [39.156s]
> Simple Java API for ODF (Simple ODF) .............. SUCCESS [1:13.071s]
> -----------------------------------------------------------------------
> BUILD SUCCESS
> -----------------------------------------------------------------------
> Total time: 6:13.310s
> Finished at: Sat Jan 07 12:38:32 PST 2012
> Final Memory: 57M/743M
> -----------------------------------------------------------------------
>
> -----Original Message-----
> From: Dennis E. Hamilton [mailto:[email protected]]
> Sent: Tuesday, January 03, 2012 20:48
> To: [email protected]
> Subject: RE: JDK 7 Results (was RE: [VOTE] Release Apache ODF Toolkit
> 0.5-incubating(RC7))
>
> Rob,
>
> Nice detective work on the vendor name.
>
> I'm fairly certain that Java 7 is not listed as a supported platform. I
> tried it just to see what might show up.
>
> - Dennis
>
> -----Original Message-----
> From: Rob Weir [mailto:[email protected]]
> Sent: Tuesday, January 03, 2012 19:18
> To: [email protected]
> Subject: Re: JDK 7 Results (was RE: [VOTE] Release Apache ODF Toolkit
> 0.5-incubating(RC7))
>
> On Tue, Jan 3, 2012 at 9:39 PM, Rob Weir <[email protected]> wrote:
>> On Tue, Jan 3, 2012 at 7:27 PM, Dennis E. Hamilton
>> <[email protected]> wrote:
>>> The tools.jar is in the usual JDK location and the packages are there.
>>>
>>> There is a way to run Maven where it shows the commands it executes and I
>>> may do that to see what the compile command looks like. Since Maven is
>>> synthesizing class-path parameters, it would be interesting to see what the
>>> compile command is and whether there is a command-line change in Java 7.
>>>
>>> I'm out of time on this for now, but I will take another crack at it
>>> eventually.
>>>
>> I think I got it. In taglets/pom.xml, look for tools.jar. The vendor
>> changed in the Java 7 version from "Sun Microsystems Inc." to "Oracle
>> Corporation". That vendor name switch causes Maven not to see that
>> dependency. Ouch.
>>
>> I changed the vendor name and it is not building under Java 7, or at
>> least it has got past that error. We'll see in another 20 minutes or
>> so if it completes.
>>
> Confirmed. It works fine on Java 7 after that change. But that said,
> I didn't think Java 7 was among our supported platforms, at least not
> yet.
>
>
> Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
> Maven home: C:\apache-maven-3.0.3\bin\..
> Java version: 1.7.0_02, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_02\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows xp", version: "5.1", arch: "x86", family: "windows"
>
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache ODF Toolkit ................................ SUCCESS [3.656s]
> [INFO] ODF Custom Javadoc Taglets ........................ SUCCESS [7:29.485s]
> [INFO] XML Schema to Template Mapping Tool: Parent POM ... SUCCESS [0.140s]
> [INFO] XML Schema to Template Mapping Tool: Library ...... SUCCESS [36.391s]
> [INFO] XML Schema to Template Mapping Tool: Maven2 Plugin SUCCESS [19.875s]
> [INFO] ODFDOM ............................................ SUCCESS
> [22:59.875s]
> [INFO] ODF XSLT-Runner ................................... SUCCESS [15.953s]
> [INFO] ODF XSLT-Runner Ant Task .......................... SUCCESS [15.719s]
> [INFO] ODF Validator ..................................... SUCCESS [1:27.078s]
> [INFO] Simple Java API for ODF (Simple ODF) .............. SUCCESS [6:22.047s]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 39:51.156s
> [INFO] Finished at: Tue Jan 03 22:10:15 EST 2012
> [INFO] Final Memory: 63M/237M
> [INFO]
> ------------------------------------------------------------------------
>
>
>
>
>
>> I wonder if we can simply list the JAR twice, once with each vendor?
>> Maven seems to ignore the one it can't find.
>>
>> I wonder how this worked at all with OpenJDK? Do they just list
>> themselves as coming from Sun for compatibility?
>>
>>
>> -Rob
>>
>>> - Dennis
>>>
>>> -----Original Message-----
>>> From: Rob Weir [mailto:[email protected]]
>>> Sent: Tuesday, January 03, 2012 13:17
>>> To: [email protected]
>>> Subject: Re: JDK 7 Results (was RE: [VOTE] Release Apache ODF Toolkit
>>> 0.5-incubating(RC7))
>>>
>>> On Mon, Jan 2, 2012 at 1:35 AM, Dennis E. Hamilton
>>> <[email protected]> wrote:
>>>> Just for fun, I also attempted to build (rc7) with JDK 7u2, since JDK 6u30
>>>> seemed to work so well.
>>>>
>>>> No joy. The Maven clean install failed with compiler errors in the very
>>>> first
>>>> compiles.
>>>>
>>>> - Dennis
>>>>
>>>> SOME DETAILS
>>>>
>>>> I don't think this is an ODF Toolkit problem. It appears to be somewhere
>>>> between Maven and JDK 7. The basic situation is that com.sun.javadoc and
>>>> other packages in the %JAVA_HOME%\lib\tools.jar are not found. I tried
>>>> several variations (but I did not restrict Maven to not use any parallel
>>>> builds).
>>>>
>>> Does Java 7 give you a tools.jar at all? If so, what happens if you
>>> just add it to the classpath?
>>>
>>> -Rob
>>>
>>> [ ... ]
>>>
