[
https://issues.apache.org/jira/browse/ODFTOOLKIT-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeremias Maerki resolved ODFTOOLKIT-312.
----------------------------------------
Resolution: Fixed
Thanks for reviewing and apply the patch, Svante!
> PATCH: Better exception handling for OdfPackage (swallows IOExceptions on
> save())
> ---------------------------------------------------------------------------------
>
> Key: ODFTOOLKIT-312
> URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-312
> Project: ODF Toolkit
> Issue Type: Bug
> Components: odfdom
> Affects Versions: 0.5.5
> Reporter: Jeremias Maerki
> Assignee: Svante Schubert
> Labels: patch
> Fix For: 0.5.5
>
> Attachments: OdfPackageExceptionHandling.diff
>
>
> Related thread:
> http://mail-archives.apache.org/mod_mbox/incubator-odf-dev/201203.mbox/%[email protected]%3E
> Executive summary: OdfPackage does too much exception catching causing real
> problems not being detected by client programs (because the exceptions are
> only logged). Similar patterns were observed when reading an ODF package. The
> attached patch tries to introduce a better exception handling throughout the
> OdfPackage class. Instead of throwing Exception, methods now throw
> IOException and SAXException. The existing load-side fault tolerance is
> preserved but the client can now abort processing if a potentially bad ODF
> file is read because exceptions thrown in the ErrorHandlers are no longer
> swallowed.
> I hope you find the proposed changes useful. They are backed by unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
