One more thing.. I have moved your new configuration file beyond source, according to the Maven example, given at http://maven.apache.org/plugins/maven-assembly-plugin/usage.html
The problem with the default manifest, might be solved, when looking deeper into the log "mvn -e -X package > log.txt", but I am running out of time.. PS: As you are already an apache committer, I have used your patch from the mail attachment. I believe the correct way is to take the attachment from an issue, but no time for the mail ping-pong atm.. ;) Thanks for the patch anyway, Svante On 19.09.2012 13:38, Svante Schubert wrote: > Hi Michael, > > I have applied your patches manual, as the merge did not work out well. > If you like even provide GIT patches and/or use github, as we have a git > read-access. > Downside it is only read-only, but I prefer to copy the diff over to a > svn rep. > > Some notes and changes to your patch noted below... > > On 13.09.2012 20:08, Michael Stahl wrote: >> hi all, >> >> i've just had a need for the ODF validator, tried to build it from >> source and failed miserably. using "mvn install" i got some weird JEE >> .war thing, > The WAR thing is the web application you might add to your local tomcat, > glassfish, whatsoever.. > The front-end is included to it. It was meant to run out-of-the-box. > Never tested the command-line, I realized that the manifest is not being > added. Tried it a while and dropped it, due to time constraints now, but > your manifest works (just had to corrected the spelling).. >> a .jar file with the sources (the point of which escapes >> me), and a validator-with-all-dependencies.jar file. the latter looked >> promising until it became apparent that it didn't, uhmmm, include the >> actual validator classes, so it didn't run. >> >> attached is my attempt to fix this; i failed to somehow add extra files >> to the existing "assembly" thing so just copied its definition from the >> maven website and added the target/classes, which seems to work but is >> likely not the best way to do this (please note that i know absolutely >> nothing about maven). > The manifest entry was wrong, I fixed the correct spelling, did you > tested it? > As you have no test case provided you need to test the latest update.. ;) >> one annoyance i have with the maven build is that it appears to download >> the ODF schemas from the OASIS site over and over again on every "mvn >> install", never noticing that they already exist on the filesystem. i >> remember a time when the validator was built with ant when that didn't >> happen. well back then one had to download all schemas once manually >> which is hardly convenient, but subsequent builds were much faster. > That time was before the Apache legal review. > I am annoyed myself, but not enough to fix it. The solution could be to > upload the various schema to the Maven repository as an artifact. > Someone needs to research on that or simply ask on the Maven list for a > solution for that problem. >> also i've noticed the lack of a .gitignore hence the second patch. > Apache is using Subversion as their house version system, but as I use > mainly git myself, I added it, although moved it to root level. >> regards, >> michael >> > Thanks, > Svante
