Hi kejia,

Great job, I will review the codes and commit it tomorrow.

2013/2/7 Kejia Ye <[email protected]>

> I just uploaded a patch to fix the issues 1-5 mentioned in
> ODFTOOLKIT-351<https://issues.apache.org/jira/browse/ODFTOOLKIT-351>
> .
>
> There's a special task for issue #1 which may not been pointed out clearly.
> It means when the replaced text is in a paragraph with a page break, the
> break settings should be kept after the replacement and no additional page
> breaks are introduced.
>
> To fix this issue in replaceWithTable method, I add a new class
> TableProperties.java and some new APIs to get/set the properties like
> fo:break-before and text:page-number.
>
> New test cases for the new APIs and regression tests for these reported
> bugs are also uploaded. Please help to review, any comments are welcomed.
>  Thanks!
>
> Regard,
> Ke Jia
>

Reply via email to