[ 
https://issues.apache.org/jira/browse/ODFTOOLKIT-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650702#comment-14650702
 ] 

Svante Schubert commented on ODFTOOLKIT-401:
--------------------------------------------

Thanks for the patch, Damjan!
I extended your patch a little with a change on my branch, where I provided 
some additional information (the file name with wrong zip size) to the 
exception.
Did not received a test document without customer data from that application I 
do not posses so there is unfortunatly not regression test, yet. But I will 
push this as soon I receive something.

Have a nice week-end,
Svante 

> NullPointerException from typo hides all ZIP exceptions
> -------------------------------------------------------
>
>                 Key: ODFTOOLKIT-401
>                 URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-401
>             Project: ODF Toolkit
>          Issue Type: Bug
>          Components: odfdom
>            Reporter: Damjan Jovanovic
>            Assignee: Svante Schubert
>         Attachments: ziphelper-npe.patch
>
>
> In SVN trunk, org.odftoolkit.odfdom.pkg.ZipHelpder.entriesToMap() has an 
> exception handler that calls System.getProperty("Java.version") which will 
> return null as it's supposed to be "java.version" (lowercase), and then 
> compares it to "1.5.0" with equals(), and calling equals() on a null 
> reproducibly generates an NPE.
> This was already reported as one of the problems in ODFTOOLKIT-353 and still 
> is not fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to