[jira] [Commented] (ODFTOOLKIT-402) ZipException on encrypted files: only DEFLATED entries can have EXT descriptor

[Svante Schubert (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ODFTOOLKIT-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650727#comment-14650727
 ] 

Svante Schubert commented on ODFTOOLKIT-402:
--------------------------------------------

My oversight, there is no exception catched, but still the problem occurs.

Added a regression test with the given document to the validator project:
org.odftoolkit.odfvalidator.InvalidPackageTest

        @Test
        public void validatePackage4() {
                String output = "";
                try {
            String name = "helloEncrypted.odt";
                        output = doValidation(name, null);
                } catch (Throwable t) {
                StringWriter errors = new StringWriter();
                t.printStackTrace(new PrintWriter(errors));
                        Assert.fail(t.toString() + "\n" + errors.toString());
                }
                Assert.assertTrue(!output.contains("Fatal") && 
!output.contains("xception"));
        java.util.logging.Logger.getLogger(getClass().getName()).info("Test 
result:\n"+ output);
        }

And used @Ignore for the existing tests to debug only the latter.
No further test document needed for this issue ;)

> ZipException on encrypted files: only DEFLATED entries can have EXT descriptor
> ------------------------------------------------------------------------------
>
>                 Key: ODFTOOLKIT-402
>                 URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-402
>             Project: ODF Toolkit
>          Issue Type: Bug
>          Components: odfdom
>            Reporter: Damjan Jovanovic
>         Attachments: helloEncrypted.odt, use-zipfile.patch
>
>
> Any encrypted ODF file written by LibreOffice reproducibly fails to open:
> Document document = Document.loadDocument(new File(args[0]), "abc");
> due to an exception produced early in parsing the ZIP file. The exception is 
> masked by the NullPointerException in the exception handler as per 
> ODFTOOLKIT-401, but if that is patched, the original exception is this:
> java.util.zip.ZipException: only DEFLATED entries can have EXT descriptor
>       at java.util.zip.ZipInputStream.readLOC(ZipInputStream.java:309)
>       at java.util.zip.ZipInputStream.getNextEntry(ZipInputStream.java:121)
>       at ReadZip.entriesToMap(ReadZip.java:64)
>       at org.odftoolkit.odfdom.pkg.ZipHelper.entriesToMap(ZipHelper.java:87)
>       at org.odftoolkit.odfdom.pkg.OdfPackage.readZip(OdfPackage.java:443)
>       at 
> org.odftoolkit.odfdom.pkg.OdfPackage.initializeZip(OdfPackage.java:422)
>       at org.odftoolkit.odfdom.pkg.OdfPackage.<init>(OdfPackage.java:250)
>       at org.odftoolkit.odfdom.pkg.OdfPackage.loadPackage(OdfPackage.java:405)
>       at org.odftoolkit.simple.Document.loadDocument(Document.java:351)
>       at local.Main.main(Main.java:21)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)