[
https://issues.apache.org/jira/browse/ODFTOOLKIT-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Svante Schubert resolved ODFTOOLKIT-433.
----------------------------------------
Resolution: Fixed
Assignee: Svante Schubert
Thank you for your patch and the description document. I have reviewed and
pushed your changes without any major adoption, only extended the test by one
line to save the document and check the XML manually once. Works fine! Although
there is still some new indentation noise, it is much better and it seems to be
a general interoperability problem among IDEs. I have not found yet an
excellent automated indent mechanism that works for all IDEs. IMHO it would be
sufficient to have something to normalize code during build time. Some wisdom
on xml:id: The ID is something that should in general not be changed, as there
might be even external documents reference to that ID, for instance metadata in
other files of the package. Think of the ID as some kind of document API. But
IBM once added this use case to the simple API and obvious had a business case.
You fixed the text:continue-list attribute, and although there might be some
related use cases, if you search for IDREF or IDREFS within
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html it is
a good improvement and serves your use case and is a fix worth to be pushed!
Tested with "mvn clean install -Ppedantic" in the following environemnt: Apache
Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T17:41:47+01:00) Java version: 1.8.0_92, vendor: Oracle Corporation
Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10",
version: "10.0", arch: "amd64", family: "dos"
> Document.updateXMLIds(...) does not update referenced id's
> ----------------------------------------------------------
>
> Key: ODFTOOLKIT-433
> URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-433
> Project: ODF Toolkit
> Issue Type: Bug
> Components: simple api
> Affects Versions: 0.6.2-incubating
> Reporter: Georg Füchsle
> Assignee: Svante Schubert
> Attachments: SectionContinuedList.odt, explanation.odt, proposal.diff
>
>
> The function void
> {{org.odftoolkit.simple.Document.updateXMLIds(OdfElement element)}}
> assigns a modified value to all xml:id-attributes inside the OdfElement.
> If there are references text:continue-list to one of the modified xml:id this
> reference wiill not be updated.
> The consequence is:
> If You will insert a Section containing interupted lists into a document by:
> {{TextDocument.appendSection(Section section, ...)}}
> the information text:continue-list will be lost. In the copy the interupted
> list will start again with number '1'
> I attached a proposal for a fix. I hope the formatting correspondes to your
> standard now.
>
> I attach document with some more detailled explanation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
