Hello Ian,

thanks for the example. Now I understand.
It makes perfect sense, that each test method saves into an own document.

Cheers,
Svante
ᐧ

2017-05-31 15:43 GMT+02:00 Ian C <[email protected]>:

> As an example look at the test in simple/draw/FrameStyleHandlerTest.java -
> it repeatedly writes to textsample.odt
>
> On Wed, May 31, 2017 at 9:33 PM, Ian C <[email protected]> wrote:
>
> > Hi Svante,
> >
> > many of the test use an original document and amend it in some way. Then
> > write out a new version usually to a new name.
> > Some tests create completely new documents. And following tests use them
> > and amend them.
> >
> > What I propose is that when a test writes out a document that it's name
> be
> > unique and traceable back to the test from which it was written.
> >
> > While this is of little consequence to the tests directly it may help in
> > debugging and also in my research.
> >
> > I will do this on my local copy of the test. But want to know if the
> > project would want the changes.
> >
> >
> >
> >
> > On Wed, May 31, 2017 at 9:25 PM, Svante Schubert <
> > [email protected]> wrote:
> >
> >> Hello Ian,
> >>
> >> aren't the original test documents part of the source directory for
> >> resources, which is the default for Maven projects.
> >>
> >> For instance for the ODFDOM project all test documents are checked into:
> >> <ODFTOOLKIT_ROOT>/odfdom/src/test/resources
> >>
> >> and during the initiation of the test are being copied to
> >> <ODFTOOLKIT_ROOT>/odfdom/target/test-classes
> >>
> >> Therefore by Maven test design, when we are writing into the 'original'
> >> document it has been already being copied into the temporary target
> >> directory of the build.
> >>
> >> Does this information help?
> >>
> >> Best regards,
> >> Svante
> >>
> >>
> >>
> >> ᐧ
> >>
> >> 2017-05-31 14:59 GMT+02:00 Ian C <[email protected]>:
> >>
> >> > Hi All,
> >> >
> >> > more feedback as a result of looking through our tests.
> >> >
> >> > I can see that many of the tests write documents. The tests write to
> the
> >> > same document names and hence overwrite the previous versions.
> >> >
> >> > I propose that we make each test write to a unique document.
> >> > This will greatly help in some of the analysis I am doing and also in
> >> > general I think.
> >> >
> >> > Any comments?
> >> >
> >> > --
> >> > Cheers,
> >> >
> >> > Ian C
> >> >
> >>
> >
> >
> >
> > --
> > Cheers,
> >
> > Ian C
> >
>
>
>
> --
> Cheers,
>
> Ian C
>

Reply via email to