[ 
https://issues.apache.org/jira/browse/ODFTOOLKIT-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Stempell updated ODFTOOLKIT-468:
----------------------------------------
    Description: 
Any inserted file still got a handle after using {{OdfPackage.insert(URI 
sourceURI, String internalPath, String mediaType)}}, as opened InputStream 
there is never closed (only an explicit System.gc() call could free the file). 
This can also lead to memory leakage of course.

I pushed a fix (closing the instancied InputStream) as pull request here: 
https://github.com/apache/odftoolkit/pull/2

  was:
Any inserted file still got a handle after using {{OdfPackage.insert(URI 
sourceURI, String internalPath, String mediaType)}}, as opened InputStream is 
never closed (only an explicit System.gc() call could free the file). This can 
also lead to memory leakage of course.

I pushed a fix (closing the instancied InputStream) as pull request here: 
https://github.com/apache/odftoolkit/pull/2


> OdfPackage file insertion got unclosed FileInputStream
> ------------------------------------------------------
>
>                 Key: ODFTOOLKIT-468
>                 URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-468
>             Project: ODF Toolkit
>          Issue Type: Bug
>          Components: odfdom
>            Reporter: Mathieu Stempell
>              Labels: pull-request-available
>
> Any inserted file still got a handle after using {{OdfPackage.insert(URI 
> sourceURI, String internalPath, String mediaType)}}, as opened InputStream 
> there is never closed (only an explicit System.gc() call could free the 
> file). This can also lead to memory leakage of course.
> I pushed a fix (closing the instancied InputStream) as pull request here: 
> https://github.com/apache/odftoolkit/pull/2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to