[ 
https://issues.apache.org/jira/browse/ODFTOOLKIT-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607038#comment-16607038
 ] 

Svante Schubert commented on ODFTOOLKIT-477:
--------------------------------------------

Hello Ibrahim,

Thanks for your patch!

It would be very cool if you could write some brief regression test that tests 
the cell padding features you have added. Like, adding a new test method in 
org.odftoolkit.simple.table.TabelCellTest, which sets a padding saves the 
document, reloads it and tests if the padding was correctly set. 

By doing so, we could simply see by loading the saved document if the padding 
was correctly set and we would have an automated regression test that would 
guarantee us that the feature will never break away unnoticed.

Best regards,

Svante

 

> Added cell padding to simple api
> --------------------------------
>
>                 Key: ODFTOOLKIT-477
>                 URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-477
>             Project: ODF Toolkit
>          Issue Type: Improvement
>          Components: simple api
>            Reporter: Adam Ibrahim
>            Priority: Minor
>         Attachments: 0001-Add-ability-to-change-padding-for-table-cells.patch
>
>
> I was creating a document where the padding on the cells mattered. So I added 
> the ability to manipuate the cell padding from the simple API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to