Hi Ashok, As I was traveling end of last week, I was only able to review your patch today after it had been closed. I have added my comments to the closed issue
https://issues.apache.org/jira/browse/ODFTOOLKIT-302 It all comes down, that you had a line too much in your patch: mDuplicatePrefixesByUri.put(namespaceURI, prefixes); The put() within a get() context was suspicious, but the method was broken anyway and I owe you that you found out and provided a patch. Thanks again, Svante On 02.02.2012 08:34, Ashok Hariharan wrote: > Hello there -- > > I am submitting a patched test case "xpathtest-case-patch.txt" and the > corresponding odt file used by the test. > > To simulate the problem -- > > 1) apply the patch xpathtest-case-patch.txt on the ODFDOM source > 2) put the XPathTest-duplicate-prefix.odt in odfdom/src/test/resources > 3) Run the src/test/java/org/odftoolkit/odfdom/dom/XPathTest.java unit > test. It fails. > 4) apply the patch odffiledom-patch.txt on OdfFileDom and run the unit > test again. It passes. > > I have added explanatory comments in the patched unit test and the > patched getNamespaceURI() > > thanks, > > Ashok Hariharan
