[ http://issues.apache.org/jira/browse/OFBIZ-179?page=comments#action_12433758 ] David E. Jones commented on OFBIZ-179: --------------------------------------
I just spent a few minutes reviewing the search_by_catalog2.patch file. These look like some great additions to the existing functionality, but there are a few issues with these changes: - a number of changes that are simply reformatting (makes it more difficult to review, plus leads to inconsistent fomatting in the file) - the locale establishment is not consistent, and the request.getLocale alone should not be used; the best method is the UtilHttp.getLocale(request) method - instead of passing around the request in addition to the session we should just pass around the request instead of the session - I don't really like the way the i18n is handled with the set/getResourceBundle methods; it's generally better to use the UtilProperties stuff directly and let it take care of the details as is done elsewhere - I'm not sure what the point is of the new CatalogConstraint... it looks like it ignores the prodCatalogId and otherwise could be more correctly called a "CategorySetConstraint", like the FeatureSetConstraint is an alternative to the FeatureConstraint > Searching product with catalog > ------------------------------ > > Key: OFBIZ-179 > URL: http://issues.apache.org/jira/browse/OFBIZ-179 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, product > Affects Versions: SVN trunk > Environment: Windows > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Attachments: search_by_catalog2.patch, search_by_catalog2_18n.patch > > > Now is not possible to search all the products inside different categories. > In detail into the front-end (ecommerce application) is now possible into the > advanced search button to searching products outside the selected catalog. > For example If I have two different Stores (Shop1, Shop2) and Catalog > (Catalog1, Catalog2) of two different Web Sites (WebSite1, WebSite2) is it > possibile to see the products of Catalog1 & Catalog2 from both of the > WebSites. > So I have made a change to the ecommerce advanced search that in case any > categories was selected it will use the categories linked to the selected > catalog for searching products. > I this case will be not more possible to see the products outside the > Catalogs of the current WebSite apart products shared between different > Catalogs. > In the backend I have add the possibility to search products by catalogs. > I this patch you can find all those changes and a lot of changes for I18n > missing. > I hope this time I have attached a patch with tabs transformed to space, if > it's not true can you tell me so I can check it. > Can some committers look at this and then if everythings is ok commits. > Thanks in advance > Marco Risaliti -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
