[ http://issues.apache.org/jira/browse/OFBIZ-280?page=comments#action_12435264 ] Jacques Le Roux commented on OFBIZ-280: ---------------------------------------
I tried to apply this patch. There are 3 parts in this patch indeed : OFBiz CSS Opentravel CSS not CSS at all I succeeded easily in the OFBiz CSS part of it after some handling (path and one hunk by hand). But I resigned for the 2 other parts. I put these 2 parts in patches above. If someone is interested (Hans ?) I let him/her applied the patches he/her wants. After some time I will close this issue. Committed in revision 446923. Jacques > links in screenlet headers : style rather than class > ---------------------------------------------------- > > Key: OFBIZ-280 > URL: http://issues.apache.org/jira/browse/OFBIZ-280 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order, party, product > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: patch-448.txt > > > In 27 ftl files, all occurrences of screenlet-headers which have one or more > links, you use > <div style="float: right;"> > This should really be a class: > <div class="boxlink"> > We have changed the css style "boxhead" to be right-aligned and would really > like the link to float on the left. If the style wasn't defined explicitly > all over the place it would be an quick change. In any case, the look should > really be defined in the CSS style sheet anyway. > example : minilastviewedcategories.ftl > <div class="screenlet-header"> > <div style="float: right;"> > <a href="<@ofbizUrl>clearLastViewed</@ofbizUrl>" > class="lightbuttontextsmall">[${uiLabelMap.CommonClear}]</a> > </div> > <div class="boxhead">${uiLabelMap.EcommerceLastCategories}</div> > </div> > > > All Comments Work Log Change History Sort Order: > Comment by David E. Jones [19/Aug/05 11:09 AM] [ Permlink ] > I agree with the need for this change. > Could someone make these changes and send over a patch? I'd be happy to > review and commit it. > Comment by Tarlika Elisabeth Schmitz [19/Aug/05 11:31 AM] [ Permlink ] > There's more of that ilk: > When you search for "<div style", you will find 41 hits. For instance for > applications/ecommerce/webapp/ecommerce/login.ftl > applications/order/webapp/ordermgr/entry/cart/minicart.ftl has bold tags for > the box header! > Doesn't the use of styles make the site non-w3c-compliant, too? > Comment by Trent Bartlem [14/Mar/06 11:00 PM] [ Permlink ] > This is the first patch I've made, so let me know if it doesn't work. > Comment by Leon Torres [16/Mar/06 05:11 PM] [ Permlink ] > Can someone commit the stylesheet changes in framework/ and website/ first? > I'll take care of the rest in applications/ and specialized/ > Also, that patch contained changes to some java files that are not on topic. > No need to resend the patch, I can do this in one line of code with find and > sed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
