[ http://issues.apache.org/jira/browse/OFBIZ-318?page=comments#action_12435628 ] David E. Jones commented on OFBIZ-318: --------------------------------------
In general this sort of use of service groups is a bad practice. They were not designed for this sort of thing, but I think Andy got on a kick trying this out with stuff he was working on after he realized it was possible. There are a few flaws to this approach. I'm all for keeping things simple, but not too simple, that just leads to more problems than it solves. In general the tools and best practices in the OFBiz framework are designed to make maintenance and customization as easy possible, with the second priority being making implementation as quick and easy as possible. Given those priorities it may take a couple minutes more to call a set of services from a simple-method instead of using a service group to implement a service, but it is a lot less flexible and ultimately leads to less than ideal work arounds. Chris: your solution to this of wrapping the service group in another service is the way to go if you're trying to avoid redoing the service group. In this case though I think the service group is crying to be tossed and re-implemented as a simple-method. The nice thing is that you can do all of the parameter mapping and extension you want now and in the future without having to re-implement anything, and making the switch is also fairly trivial. > Receipt of multiple units of serialized inventory error > ------------------------------------------------------- > > Key: OFBIZ-318 > URL: http://issues.apache.org/jira/browse/OFBIZ-318 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: product > Reporter: Chris Howe > Attachments: serialized.patch, serialized2.patch > > > When receiving multiple units of serialized inventory, only a single > inventory item is created and the shipment is considered received because the > shipment accepts all units. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
