[ http://issues.apache.org/jira/browse/OFBIZ-320?page=comments#action_12436033 ] Si Chen commented on OFBIZ-320: -------------------------------
Cameron, Thanks for your patch and for contributing. I just checked http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices, and I did put: For consistency, please make your patch files from the ofbiz/ directory. How could I make it more clear in the future? Si > Party Manager: Relationships: Add Relationship: Better role type dropdown > ------------------------------------------------------------------------- > > Key: OFBIZ-320 > URL: http://issues.apache.org/jira/browse/OFBIZ-320 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: party > Affects Versions: SVN trunk > Environment: Any. I am using JDK1.5 + MySQL 5.0 on Ubuntu 6.06 and > Win XP. > Reporter: Cameron Smith > Assigned To: Jacques Le Roux > Priority: Trivial > Fix For: SVN trunk > > Attachments: 1566388.patch > > > This post is a followup to a discussion with Si Chen on the OpenTAPS General > Users Forum. > https://sourceforge.net/forum/forum.php?thread_id=1566388&forum_id=487771 > Currently there are 4 dropdowns on this screen, which show a list of all Role > Types in the system, when in fact the underlying schema will only accept Role > Types which the parties in question already have. For 2 of these dropdowns, > the session already knows the party involved, so the attached patch makes the > dropdown present only the available RoleTypes. Much easier to use, and > eliminates chance of getting a grotty error message when you submit. > For the other 2 lists, either improve the error messages (see my original > post on the forum), or use Ajax. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
