[ http://issues.apache.org/jira/browse/OFBIZ-75?page=comments#action_12436145 ] Marco Risaliti commented on OFBIZ-75: -------------------------------------
Hi Jacques, I'm sorry but I'm not agree with this behaviour if I have understood correctly. Normally to localize descriptions we will take before if exists a localized description and only after we take the general ones. For example also the uiLabels and EntityLabels in OFBIZ use this behaviour. I don't like to set the description of the categories to null because what happens in case there aren't any alternative locale defined for the selected locale/categories ? Probably it's shows a blanks description ? What's happens in all the application where this change is not applied its probably shows a null description ? In my opinion it's better to check if there is an alternative locale definition and in case it doesn't exists take the description of thecategory without set to null the category description. Anyway I think that this is a great improvement to all the users that has internazional ecommerce sites and want to see different categories description for different locales. Thanks a lot Marco > I18n of categories > ------------------ > > Key: OFBIZ-75 > URL: http://issues.apache.org/jira/browse/OFBIZ-75 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: ecommerce, order > Affects Versions: SVN trunk > Reporter: Jacques Le Roux > Assigned To: Jacques Le Roux > Fix For: SVN trunk > > Attachments: i18nCateg.patch, injectGizmos.xml, injectGizmos_2.xml > > > I propose this patch for i18n of categories. I found 3 places where I had to > do something : eCommerce (Browse Categories and Last Categories) and > creation of order. > I wrote it in BSH/FTL but I'm now asking myself whether it would not be > better to write BSH part as a method of CategoryWorker. Because it's used in > 2 files and could be consuming (not sure of overhead, cache ?). > Attached is a data file wich creates DataResources (DESCRIPTION) in french > and english for Gizmos categories. You may use it for test but have to delete > the Gizmos categories (100, 101, 102) descriptions to see the changes > (descriptions overrides else) > I think I'll do something also for Catalog ASA I I'll find some time to... > I did not change the MIT headers to ASL 2. I can do it in another patch if > this one is OK and there is no pb with this change. > Jacques -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
