Nope, no objection here. Of course, as for the empty title problem...
I haven't looked at that code for a while but chances are it's a bit
messy. As long as it doesn't break things you know I'm always for
ripping up/out code... ;)
-David
On Sep 23, 2006, at 12:28 AM, Si Chen (JIRA) wrote:
[ http://issues.apache.org/jira/browse/OFBIZ-240?
page=comments#action_12437029 ]
Si Chen commented on OFBIZ-240:
-------------------------------
Hey everybody, let me know if there are any objections to this.
Otherwise I'll commit it on Monday.
selectAll on multi-forms
------------------------
Key: OFBIZ-240
URL: http://issues.apache.org/jira/browse/OFBIZ-240
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: framework
Reporter: Si Chen
Assigned To: Si Chen
Priority: Minor
Attachments: selectAllSmallestImpact.patch
Add a "select-all" button to multi-forms. Comments from mailing
list:
Si,
I think you're right that this is broken. I just looked around for
anything in the form widget code referring to the "toggleAll"
method and it's not there... So, yeah, in the HtmlFormRenderer we
should add the normal checkbox to the header as is used elsewhere,
like this:
<input type="checkbox" name="selectAll" value="Y"
onclick="javascript:toggleAll(this, 'selectAllForm');"/>
The "selectAllForm" string should be replaced dynamically with the
form name, and then that should do it... The rowSubmit fields
should already be going in with the use-row-submit attribute set
to true.
-David
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: http://issues.apache.org/jira/secure/
Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/
software/jira
