[ http://issues.apache.org/jira/browse/OFBIZ-68?page=all ]

Jacopo Cappellato closed OFBIZ-68.
----------------------------------

    Resolution: Fixed

Chris,

your last patches were no more applicable because some of the artifacts have 
been modified so I've manually applied them with some differences (because 
there were a few issues, such as some bad references to missing resources, 
probably custom templates); if you can, have a look at them to see if 
everything work as expected.

Really thank for your work,

Jacopo

> Break up application templates with multiple screenlets
> -------------------------------------------------------
>
>                 Key: OFBIZ-68
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-68
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>            Reporter: Chris Howe
>         Assigned To: Jacopo Cappellato
>         Attachments: cssChange.patch, OrderEntryOrderHeader.patch, 
> OrderOrderHeader.patch, showPromotionDetails.patch, ViewQuote.patch, 
> ViewRequest.patch
>
>
> There are currently 7 freemarker files in the order applications that have 
> multiple screenlets in the same template file.  They are:
> entry/cart/showcart.ftl
> entry/cart/showPromotionDetails.ftl
> entry/order/orderheader.ftl
> entry/poheader.ftl (may not be used)
> order/orderheader.ftl
> quote/ViewQuoteInfo.ftl
> request/ViewRequestInfo.ftl
> I would like these to be split up.  Screenlets, when defined make up a good 
> chunk of reusable code.  When multiple screenlets inhabit the same template 
> file, you either have to reuse all of the code or none if it.  By splitting 
> these up, the parts are more likely to be reused than the whole.
> Because the order application is the base for so many custom applications in 
> addition to ecomerce and wholesale and salesrep, making it reusable will 
> lower the maintenance those applications require.  Please vote on this and I 
> will submit patches.  Thanks

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to