[ http://issues.apache.org/jira/browse/OFBIZ-400?page=comments#action_12446572 ] Jacopo Cappellato commented on OFBIZ-400: -----------------------------------------
The patch is ok for me. However the existing method looks a bit odd: it takes objects as input parameters (e.g. a Double for the amount and price) and the only primitive variable is the one for quantity. So I'd prefer to modify the signature of the method instead of adding a new one as proposed by Chris (that however is the best practice in general). Then we'll have to patch the ShoppingCartEvents class (in two points) to reflect this change. > Allow ShoppingCartHelper.addToCart to be called from simple-method > ------------------------------------------------------------------ > > Key: OFBIZ-400 > URL: http://issues.apache.org/jira/browse/OFBIZ-400 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Reporter: Chris Howe > Priority: Minor > Attachments: ShoppingCartHelper.patch > > > To my knowledge a primitive type double cannot be sent from > <call-object-method> in minilang. So to allow ShoppingCartHelper.addToCart > to be usable from minilang there are three possible solutions. > 1)Change minilang to pass primitive type double (if there is a way to do this > already, disregard this issue) > 2)Change addToCart to accept Double quantity instead of double quantity > 3)Create additional method that accepts Double quantity and then passes that > to the current addToCart with a quantity.doubleValue() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
