On Nov 2, 2006, at 5:45 PM, Si Chen wrote:
1. sendMail returns error when there's a problem sending the email. The problem is that this rolls back a whole transaction, including one that is sending emails to everybody on a contact list. I modified it to return failure instead, and it seems to be working better. Is it ok if I change it to returnFailure, or would it cause any problems?
Another solution might be to split this into two services, one which iterates over the contact list and another that sends out each mail and updates the relates database records. The second service could then have the require-new-transaction attribute set to true to isolate those errors.
2. UtilValidate.isEmail has code which checks for the "." in an email commented out in 2001. Do we still want this commented out? Is it ok if I made two forms of this, one with an optional parameter to require the dot? That would make our email program much more robust.
There was some discussion a long long time ago about this and how some valid email addresses don't have a dot in them. I don't know how that could be except perhaps on an internal network or something. I'd be fine with requiring a dot after the at sign, but it would be good to get more feedback on this...
-David
