Something that comes to mind from this is that it would be great if the commiters were to create more jira issues themselves. I'm guessing there are loads of things they would like to see improved and it would give newer contributors like myself a clearer direction on what we can work on that will increase our experience and at the same time help move the project forward.

Regards
Scott

David E. Jones (JIRA) wrote:
[ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12448853 ] David E. Jones commented on OFBIZ-444:
--------------------------------------

I just sent a message to the private ofbiz list about a larger issue related to 
this, so I'm adding relevant comments here.

I'm not sure I like this design... I'd rather see a more generic "while" operation that 
would be like the "if" operation. A while-compare is okay, but more like the if-compare 
and related operations which are limited in use and really mainly exist for legacy reasons. They 
have not been removed because even though something better is now available, they aren't really 
causing any problems (like the field-to-field, field-to-env, and related operations were, which is 
why it became a priority to remove them).

I don't have time to look at this more right now, so I'd appreciate some 
feedback on this. My proposal would be to remove this while-compare operation 
and add the more general while operation.

add a while-compare operation to minilang
-----------------------------------------

                Key: OFBIZ-444
                URL: http://issues.apache.org/jira/browse/OFBIZ-444
            Project: OFBiz (The Open for Business Project)
         Issue Type: Improvement
         Components: framework
   Affects Versions: SVN trunk
           Reporter: Scott Gray
        Assigned To: Jacques Le Roux
           Priority: Minor
            Fix For: SVN trunk

        Attachments: while-compare.patch


Hi All
I've added a while-compare operation to minilang which a mirrors java 'while' 
loop using the same condition definition as the if-compare tag
Regards
Scott


Reply via email to