[
http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449147 ]
Ashish Vijaywargiya commented on OFBIZ-450:
-------------------------------------------
Hi Macro,Jacques & Jacopo,
Here are my comments.("Hey Macro your work was excellent")
1) Everything looks fine so this patch can be applied without any delay.
2) We should keep the "View Entity"(old one) title instead of "Entity View" for
all the view entity.
3) I think we can remove the "style='FONT-SIZE: xx-small;'" from
EntityMaint.ftl.If you think that the links(buttons) comes very close to table
border then
you can increase the "cellpadding" by one i.e increase to "3" from "2" at lines
24 and 65.
4) There are only small mistake in ftl file of the closing column position of
<#if> and deviated position of <td> tag.(Please commit this patch I will take
take care of all this small things and will send the patch)
Rest code from bsh and ftl is excellent.
Once again Thanks Macro for such a nice contribution.
Regards
Ashish Vijaywargiya
> Migrate Entity Maintenance from JSPs/region to Screen widget
> ------------------------------------------------------------
>
> Key: OFBIZ-450
> URL: http://issues.apache.org/jira/browse/OFBIZ-450
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Priority: Minor
> Attachments: entity_maint3.patch
>
>
> This patch contains the migration from JSPs/region to Screen widget.
> I have re-applied also the changes that has been done into the issue
> OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen)
> recently committed.
> After this patch the entity maintenance has still two minor issues that they
> was also present into the previously version written in JSPs/region :
> 1- sometimes the html tables overflow the screen.
> 2- in case of entity that has an group by clause specified the FindGeneric
> page will show an error.
> That's all what I have done.
> Please give me some feedback on this issue so if everythings is ok I can
> continue to migrate the next part of the Webtools application (Entity
> Reference).
> Can also the committer tell me if the patch has a correct formatting and
> absence of tabs and correct relative paths.
> Thanks in advance
> Marco
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
