[ 
http://issues.apache.org/jira/browse/OFBIZ-405?page=comments#action_12450582 ] 
            
Si Chen commented on OFBIZ-405:
-------------------------------

This looks like a good idea.  

1.  The InvoiceWorker method should be implemented as a new 
InvoiceWorker.getInvoiceTaxTotal() and an InvoiceWroker.getInvoiceNoTaxTotal(). 
 The getInvoiceTaxTotal can be a simple getRelatedByAnd("InvoiceItem", 
UtilMisc.toMap("invoiceItemTypeId", "INV_SALES_TAX")) and getInvoiceNoTaxTotal 
can just subtract getInvoiceTaxTotal from getInvoiceTotalBd().  I think that is 
a cleaner implementation and a better way to structure the API methods.

2.  What is the consensus here about what to put on the xsl:fo?  Is what  Eriks 
have here oK?

> Showing invoice total with and without tax
> ------------------------------------------
>
>                 Key: OFBIZ-405
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-405
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>         Assigned To: Si Chen
>            Priority: Minor
>         Attachments: invoicenotax.diff
>
>
> This is one more from the series of making invoice usable for countries using 
> VAT. Of course this might be used by others too. 
> Attached diff adds a line in the invoice showing total without tax (i.e. 
> currently without amount of items of Invoice Sales Tax type) and the 
> corresponding function to calculate that.
> From my understanding by using this (together with previous diffs on showing 
> Tax ID in the invoice), the invoice becomes usable in EU countries.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to