[ http://issues.apache.org/jira/browse/OFBIZ-453?page=comments#action_12450988 ] David E. Jones commented on OFBIZ-453: --------------------------------------
Fabian: please note some details for future contributions: 1. use 4 spaces for indentation (not tabs) 2. put spaces after keywords like if, while, etc and around most + signs 3. when creating a patch, do it from the ofbiz directory (this one was 4 directories above) Note that these and more details are described here and I highly recommend reviewing them: http://docs.ofbiz.org/x/r Thanks, -David > XML import from Webtools Entity Export fails when (e.g.) umlauts are in the > via Webtools generated XML files > ------------------------------------------------------------------------------------------------------------ > > Key: OFBIZ-453 > URL: http://issues.apache.org/jira/browse/OFBIZ-453 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Linux 2.6.18.1, x86_64 with UTF-8 environment and file > system / The problem exists on Windows XP, too. > Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_08-b03) > Apache OFBiz (SVN Trunk) > Reporter: Fabian Gorsler > Assigned To: David E. Jones > Fix For: SVN trunk > > Attachments: patch-v2.txt, patch-v3.txt, patch.txt > > > Hi, > if you have entities filled up with (e.g.) German umlauts, you won't be able > to import them via Webtools. The characters are writtend directly to the XML > file and the parser can't read them while import. In order to import the > files you would have to change all umlauts to their corresponding XML > entities (e.g. Ä --> ä). Files with XML entites can be imported w/o any > problems and the data can be stored and represented correctly. > The attached patch fixes the issue. The patch replaces each char with an > value bigger than 0x7F with &#NNN; - this means that there will just the > ASCII chars will appear in the XML exports. CDATA doesn't need to be exported > this way. Their content will be "untouched". All changes to characters will > be logged to the INFO-facility - this could perhaps be switched to the > DEBUG-facility. Only org.ofbiz.entity.GenericEntity was changed, no other > files were modified for this patch. > Please note that I justed tested this case with German umlauts. Please check > the behavior with other special characters, too. > HTH and go for the release. :-) > For more information see this thread on ofbiz-user: > http://mail-archives.apache.org/mod_mbox/incubator-ofbiz-user/200611.mbox/[EMAIL > PROTECTED] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
