[ 
http://issues.apache.org/jira/browse/OFBIZ-495?page=comments#action_12452603 ] 
            
Adrian Crum commented on OFBIZ-495:
-----------------------------------

David,

Thank you very much for reviewing this! I'll adress the formatting/patch issues 
after it has been discussed - I figured I will be rewriting sections after it 
has been evaluated. I wanted to get it out there ASAP so people could comment 
on it, and for some reason my SVN client started acting flakey.

I don't know about the dozens of lines thing. Most of it I wrote from scratch. 
The only existing file that was modified (outside the example component) was 
UtilMisc. As far as I know I didn't reformat that. I'll take a look at it 
though.

The Java classes were used so they can be subclassed or wrapped with other Java 
classes. I was trying to make it as flexible/extensible as possible.

By the way, for anyone reviewing this - the example component is just being 
used to demonstrate the feature. That part of the patch is not intended to be 
made part of the project.

Thanks again for taking a look at this. I'll address your suggestions once 
everyone has commented.


> User Preferences Feature
> ------------------------
>
>                 Key: OFBIZ-495
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-495
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework.patch
>
>
> The User Preferences Services are intended to store and retrieve the current 
> user's  preferences. User preferences can be used to control UI elements, 
> frequently used search and report criteria, and more. 
> That attached patch should be applied to the framework folder of revision 
> 475825. Build OFBiz and the framework/user folder. Run ant-install. Browse to 
> https://127.0.0.1:8443/example/control/UserPrefDemo

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to