[ http://issues.apache.org/jira/browse/OFBIZ-484?page=comments#action_12453597 ] Jacques Le Roux commented on OFBIZ-484: ---------------------------------------
Jacopo, Thanks for the explanation. Strange : I tried another one with a $57 total. Received only $40 and this time the order was automatically approved. I can't see what was the difference with the 1st order but anyway yes there is something wrong there. Somehting odd too : there is a cancel button for the payment. But if you use it after that you can't change order status (or am I missing something here ?). For what is this cancel button for ? Working perfectly with you patch. Thanks > Wrong total of offline payments received is calculated by the > org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method > ---------------------------------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-484 > URL: http://issues.apache.org/jira/browse/OFBIZ-484 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: order > Affects Versions: SVN trunk > Reporter: Jacopo Cappellato > Assigned To: Jacopo Cappellato > Attachments: offline_payment.patch > > > It should fix an issue I've discovered in the way the total total of offline > payments received is calculated by the > org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method. > I think that the new amount received is summed two times to the total of > already received offline amounts. > For example, if the order total is $80, and you receive an offline payment of > $50, due to the bad calculation, the method says 50+50 = 100 > 80 and so > approves the order. > Could you please review the attached patch (that fix the issue)? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
