[ 
http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12453787 ] 
            
David E. Jones commented on OFBIZ-498:
--------------------------------------

This patch is a major improvement, and even with a few flaws the main stuff 
seems to be working just fine.

A few notes:

1. the finalizeOrder and finalizeOrderError request-map definitions should 
ideally be removed from the controller.xml file in the ecommerce webapp; this 
is referred to in just a couple of places, including the billsettings.ftl file 
for the payment method type of GC, and in the loadCartFromQuote request; both 
of these should be "modernized" 

2. the processPaymentSettings.bsh file was under the src directory and in the 
ecommerce/misc package; all such scripts should go under the script directory, 
and I created a new package for it to be more consistent: ecommerce/order

3. the Shipping Address link appears to be enabled even when the initial 
customer info is not yet in place

4. the header items really should submit the form on each page in addition to 
going to the other step (customers tend to do this sort of thing thinking their 
changes will be saved; we did this in the normal checkout process if whoever 
works on this wants an example)

Anyway, there may be more stuff but for now this is in SVN rev 479879.



> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
>                 Key: OFBIZ-498
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-498
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Tim Ruppert
>         Assigned To: David E. Jones
>         Attachments: anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the 
> training in Ephraim.  The team that contributed to this was David Jones, Amit 
> Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the 
> best of our ability. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to