[ http://issues.apache.org/jira/browse/OFBIZ-528?page=comments#action_12456709 ] Cameron Smith commented on OFBIZ-528: -------------------------------------
David, please read my previous comments carefully - I specifically did not submit anything as a patch because I wanted your and others' feedback, and also because I wanted to do more testing beforehand. There is no point me submitting a patched viewprofile.sh if there are 10 other scripts which will break in the same way because of null-handling, but I did not come across them! If there are web-based regression tests for OFBiz I will happily run them, but I believe we do not yet have these. Which is why I reckon it would be better, for such a fundamental bit of the system, for someone else to read over the code changes. I am happy to submit the Interpreter.java and BshClassManager.java changes as patches, but against what? Since these files are not in the OFBiz source tree, and much of the rest of the code has changed between 1.3.x and 2.x, I believe I should submit them as patches versus Beanshell source, and not against your original 1.3.x patched versions. What do you think? Finally, my understanding is that the OFBiz weekly builds which I am using come straight from the trunk, at a certain known SVN version. Since it is impractical for me to check out the source directly from trunk (due to bandwidth issues here in Moz), what I have done in previous patches I have submitted, is downloaded the immediately previous weekly build (which still includes .svn subdirs), "linked it" to the SVN trunk via Subclipse, and then manually updated the files in the specific area I am changing to the trunk version if necessary. Finally, I make the patch against these trunk versions. I await your feedback on these points before proceeding. > Upgrade Beanshell library to version 2.0b4 > ------------------------------------------ > > Key: OFBIZ-528 > URL: http://issues.apache.org/jira/browse/OFBIZ-528 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: Windows XP, MySQL 5.0, JDK1.5, ofbiz_opentaps_473442 > Reporter: Cameron Smith > Attachments: bsh-2.0b4-mod-ofbiz.jar, BshClassManager.java, > Interpreter.java, viewprofile.bsh > > > As discussed recently on ofbiz-users mailing list, I proposed to upgrade the > Beanshell jar used by OFBiz (framework/base/lib/scripting/bsh.jar), which is > based on a 1.3a1, to the current "stable" version, 2.0b4. > This has the following advantages: > - JDK1.5 interpretation capability > - various bugfixes > However as explained by David E. Jones here: > http://docs.ofbiz.org/display/OFBTECH/OFBiz+Customized+BeanShell+Source+%28with+ParsedScript+object%29 > ...it will be necessary to patch the source to allow for the script parsing > on which OFBiz depends. > This fix MAY also resolve this bug: > https://issues.apache.org/jira/browse/OFBIZ-303 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
