Unnecessary extra cells on list based tables
---------------------------------------------
Key: OFBIZ-542
URL: http://issues.apache.org/jira/browse/OFBIZ-542
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: framework
Reporter: Valentina Sirkova
Hey guys!
I noticed tables that are list - based, have one extra header cell and one
extra row cell. The header cell is generated by the methods
renderFormatHeaderRowFormCellOpen and renderFormatHeaderRowFormCellClose
(HtmlFormRenderer.java). The row cell is generated by the methods
renderFormatItemRowFormCellOpen and renderFormatItemRowFormCellClose
(HtmlFormRenderer.java). These two cells appear no matter if they should or
should not. I browsed through the java implementation of the list form and
reached the following conclusion:
For the extra header cell:
The method renderFormatHeaderRowFormCellOpen for example, is called in
renderHeaderRow(ModelForm.java). As far as I got, there are 3 loops that are
responsible for the cells generation.
The first one visualizes the display,display_entity and hyperlink fields.
The second one viusalizes the other fields and if there are some they are put
in that extra cell.
But if for example the list has only display,display_entity and hyperlink
fields then after the second loop the extra cell is generated though it is not
necessary.
My solution to that problem is to add one boolean variable which is set to true
if after the first loop the end of the list is reached. This flags the
situation when all of the fields are of type display, display_entity or
hyperlink.
For the extra row cell the situation and solution is the same.
My patch fixes that problem.
Thanks: Valentina
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
