David,
thanks for your comments. In fact I noticed pattern recently and used it in
patch applied to following issue.
https://issues.apache.org/jira/browse/OFBIZ-585

Regards
Anil Patel


On 1/3/07, David E. Jones (JIRA) <[EMAIL PROTECTED]> wrote:


    [
https://issues.apache.org/jira/browse/OFBIZ-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462155]

David E. Jones commented on OFBIZ-547:
--------------------------------------

Yes, I guess a commit is a good way to get someone, especially someone
like me, to review it!

Anyway, this all looks pretty safe, and more closely follow the pattern
used with the createProduct service.

BTW, in general the use of "entity-one" is far more effective and less
error prone than the use of "find-by-primary-key". The main reason for this
is that the field mappings are done with sub-elements, not with a Map that
must be created and worried about.

> Duplicate Id error on Create New FixedAsset
> -------------------------------------------
>
>                 Key: OFBIZ-547
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-547
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Assigned To: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: FixedAssedIdDuplicateMessage_Update1.patch
>
>
> While creating a New FixedAsset, if user enters FixedAssetId that
already exists in system, Unfriendly message is returned and existing
fixedAsset is opened in Edit mode.
> 1) The error message should be easier to understand by user.
> 2) Existing fixedAsset should not be opened in edit mode, this confuses
user with Idea that fixedAsset was created.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



Reply via email to