[ 
https://issues.apache.org/jira/browse/OFBIZ-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462692
 ] 

Chris Howe commented on OFBIZ-588:
----------------------------------

>>
<td><div class="tabletext"><b>ID</b></div></td>
should probably become
<th>ID</th>
(to all: is it correct?) 
<<

It's often times correct.

<th> is for table header.  For instance when you have tabular data, the cells 
for the header row should be <th>

However, many of the forms that have <b> in them are the equivalents of the 
"single" type form from the form widget.  These should (depending on the 
pattern OFBiz would like to adopt) use a <label></label> tag inside the 
<td></td>.  

http://www.w3.org/TR/html4/interact/forms.html#h-17.9

These should not use the <th> tag, as it makes styling the single form very 
difficult using the same css for tabular data.

As there are varying opinions on the "correct" way to do html in concert with 
css, one could certainly have the opinion that the <label> tag shouldn't be 
used, but I think that same logic would dictate that there is no need to change 
the current tabletext pattern.  I personally have no opinion on this either way 
as long as it was consistent.

> Replace all div class="tabletext" wrappers with <p> or just remove them and 
> set the style info in the BODY element in the css file
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-588
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-588
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Sub-task
>          Components: accounting, content, ecommerce, framework, hhfacility, 
> humanres, manufacturing, marketing, order, party, product, workeffort
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Accounting_Jan06.patch, Product_Jan06_Phase1.patch, 
> WorkEffort_Jan06.patch
>
>
> all <div class="tabletext"> wrappers can be removed, the exception being 
> where they are used like <p>s - the default text style can be set on body;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to