OK, I understand what you were meaning now. I was thinking that you were asking about the rightness of your own code. Now I understand that you propose to commit this snippet.
I have no right to commit in this component (order) so I will wait for an official commiter to do it. Furthermore this is not a right way to contribute to the project, please read here : http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices Thanks for your work Jacques > i guess the features in ofbiz are quite interlinked and code is reused in > multiple applications. So just wanted to be sure, if thers are another file where such code was supposed to be or it was fine to put it in these fines. > > If the code is fine, can you commit it, such that one does not wonder why > attributes dont show up in product pages. > > Rohit > > > > ----- Original Message ---- > From: Jacques Le Roux <[EMAIL PROTECTED]> > To: [email protected] > Sent: Tuesday, July 25, 2006 8:46:37 AM > Subject: Re: Users - How to Create Product Properties or Details > > > Hi Rohit, > > It seems rather good but what do you exactly mean (want t to know ?) when you > say "the right method to edit files in future" ? > > Jacques > > > > > > hi jacopo, > > > > i was able to get this done. i feel pretty proud of this, this is my first > > step towards learning ofbiz. > > > > i made the following additions: > > > > > > 1) In order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productdetail.bsh > > > > // get the product attribute(s) > > attribute = product.getRelated("ProductAttribute"); > > context.put("ProductAttribute", attribute); > > > > 2) In > > component://order/webapp/ordermgr/entry/catalog/marketplace_productdetail.ftl > > > > <#-- attributes of product --> > > > > <#if ProductAttribute?has_content> > > > > <#list ProductAttribute as ProductAttributes> > > <div class="tabletext"> > > ${ProductAttributes.attrName}: ${ProductAttributes.attrValue}</div> > > </#list> > > </#if> > > <#-- attributes of product END --> > > > > I will appreciate if you just let me know if this is the right method to > > edit files in future, or there is another better way. > > > > Thanks > > > > rohti > > -- > > View this message in context: > > http://www.nabble.com/How-to-Create-Product-Properties-or-Details-tf1634919.html#a5484153 > > Sent from the OFBiz - User forum at Nabble.com.
