I'm fine with upgrading bsh, but there's a bit more to it than you
describe here.
One of the other major bsh using classes in OFBiz is
OfbizBshBsfEngine. It uses the Interpreter.ParsedScript which I
implemented in order to support caching parsed scripts in the OFBiz
central cache. If something like that is implemented in BSH now it
would be fine, but I don't think that's the case because when I sent
this over to contribute it back I don't think Pat understood what we
were trying to do using BSH in OFBiz so he just responded that the
current facilities for doing this is all that we would need (ie using
a single interpreter and wrapping all scripts in methods... that just
won't work for us).
-David
On Dec 5, 2006, at 5:09 PM, Cameron Smith wrote:
Related to the current discussion about JDK1.5 compatibility and
JAR upgrades, I'd like to raise the possibility of upgrading bsh to
the current "stable" version, 2.0b4. This version is compatible
with JDK1.5, and I have used it without hitches on another project
for over a year, without problems.
I would specifically like to upgrade to it, to support the ZK rich
client library (www.potix.com), which requires it.
The main problem with the upgrade is that the API for parsing and
holding onto scripts has changed substantially, which will require
quite a few changes in BshUtil and associated classes. I'd be
happy to do/help with the rewrite but I would first like to know:
a. What are other opinions about this upgrade?
b. Is there any documentation about the philosophy of BshUtil?
c. Are there any regression tests for BshUtil, given that bsh is
used pretty extensively throughout OFBiz?
cameron
Send instant messages to your online friends http://
uk.messenger.yahoo.com