>-----Original Message----- >From: [email protected] [mailto:[email protected]] On Behalf Of >Marcel Holtmann >Sent: Friday, November 20, 2009 9:31 PM >To: [email protected] >Subject: RE: Patch on unsupported AT command > >Hi Yang, > >> >> >+ g_at_chat_add_terminator(chat, "+EXT ERROR:", 11, FALSE); >> >> >+ g_at_chat_add_terminator(chat, "+CME ERROR:", 11, FALSE); >> >> >+ g_at_chat_add_terminator(chat, "+CMS ERROR:", 11, FALSE); >> >> >+ g_at_chat_add_terminator(chat, "NO ANSWER", -1, FALSE); >> >> >+ g_at_chat_add_terminator(chat, "CONNECT", -1, TRUE); >> >> >+ g_at_chat_add_terminator(chat, "NO CARRIER", -1, FALSE); >> >> >+ g_at_chat_add_terminator(chat, "BUSY", -1, FALSE); >> >> >+ g_at_chat_add_terminator(chat, "NO DIALTONE", -1, FALSE); >> >> >+ g_at_chat_add_terminator(chat, "ERROR", -1, FALSE); >> >> >+ g_at_chat_add_terminator(chat, "OK", -1, TRUE); >> >> >> >> I really don't like this. Lets keep the non-standard terminators in a >> >> separate list. I don't want the vast majority of the drivers incurring >> >> the >> >> cost of multiple g_new/g_frees. >> > >> >I have to agree on this. We should keep the penalty for well behaving >> >cards as small as possible. >> >> Thank you for the comments. Modified patches are attached! > >please do casts with a space between. Like (char *) terminator etc. Also >why do you bother with making it const. Just leave that out. Since you >do actually copy the string anyway.
Fixed! > >Regards > >Marcel > > >_______________________________________________ >ofono mailing list >[email protected] >http://lists.ofono.org/listinfo/ofono
0001-Framework-to-support-non-standard-terminator.patch
Description: 0001-Framework-to-support-non-standard-terminator.patch
0002-Support-Huawei-specific-terminator.patch
Description: 0002-Support-Huawei-specific-terminator.patch
_______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
