Hi Marcel, > > + if (utf8 == NULL) > > + return FALSE; > > + > > + item->text = utf8; > > Why bother with utf8 variable? Just do > > if (item->text == NULL) > return FALSE; >
I actually find this acceptable because 'item' is a return structure, so we should avoid modifying it in case of an error. Regards, -Denis _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
