Hi Matthias,
> The Wavecom WMP100 assumes CPIN to be the final response, therefore some
> special handling is neccessary (see
> 6d28f82dc1ccb3de3a028a88eafb96fb001c7e61). Now the vendor id
> OFONO_VENDOR_WAVECOM is passed with all "*create" functions.
I massaged the commit message and pushed the patch. I did make two small
changes afterward:
> + if (!channel) {
> + return -EIO;
> + }
Coding style requires this to be without braces (all single statement blocks
if/while/for should not have braces)
> +
> + /* Could not figure out whether it is fully compliant or not */
> + syntax = g_at_syntax_new_gsm_permissive();
> + //syntax = g_at_syntax_new_gsmv1();
Commented out code is not a good idea, if you're not sure about something
reflect it in the comment.
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
