Hi Andrew and Denis,

>-----Original Message-----
>From: [email protected] [mailto:[email protected]] On Behalf Of
>Denis Kenzior
>Sent: Monday, April 26, 2010 11:39 PM
>To: [email protected]
>Subject: Re: [PATCH 2/6] stkutil: Move advance of ctlv to decicated proactive 
>commands
>parser
>
>Hi Andrew,
>
>> Hi Yang,
>>
>> On 26 April 2010 12:29, Yang Gu <[email protected]> wrote:
>> > Not all the proactive commands have comprehension tlv other than command
>> > details and device identities. So the appropriate code should be moved to
>> > decicated parser if needed.
>>
>> Maybe parse_dataobj() would be a better place?
>
>Agreed, lets not repeat this in every single command parser.

Really good advice:) I will modify the patches.

>
>Regards,
>-Denis
>_______________________________________________
>ofono mailing list
>[email protected]
>http://lists.ofono.org/listinfo/ofono

Regards,
-Yang
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to