Hi Yang, On 11 May 2010 05:01, Gu, Yang <[email protected]> wrote: > Hi Andrew, > >>+#define NO_DURATION { .interval = 0x00, } >>+#define NO_TEXT { .text = NULL, .yesno = FALSE, } > > There is no need to define these as static variables will be initialized to > zero automatically. We must guarentee zero means non-existence. > If some meaningful initialization happens to be missed, later check would > catch them. Hope this can save several lines of code;)
Good point, I'll resend without the initialisations to zero. (I swear I had one test fail at one point, but it succeeded when running in gdb, so I added the initialisations and it started to work... now it works either way) Regards _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
