Hi Inaky, > From: Inaky Perez-Gonzalez <[email protected]> > > write_file(), as written wasn't transaction-safe; a crash bewtween a > file being open and the buffer being written before a safe close would > leave the file with a set of undetermined contents. > > Modified to the file is written to a temporary file name; once > completed, it is renamed to the final name. This way, a crash in the > middle doesn't leave half-baked files. > + /* Now that the file contents are written, rename to the real > + * file name; this way we are uniquely sure that the whole > + * thing is there. */
Again, prefer multiline comments to be in a certain format > + unlink(path); > + /* conserve @r's value from 'write' */ > + if (link(tmp_path, path) == -1) > + r = -1; > +error_write: > + unlink(tmp_path); > +error_mkstemp_full: > +error_create_dirs: > + g_free(tmp_path); > g_free(path); > return r; > } > And I get trouble applying your patch: Applying: write_file: make transaction-safe /home/denkenz/ofono-master/.git/rebase-apply/patch:13: trailing whitespace. /* /home/denkenz/ofono-master/.git/rebase-apply/patch:22: trailing whitespace. */ /home/denkenz/ofono-master/.git/rebase-apply/patch:75: trailing whitespace. Regards, -Denis _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
