Hi Andrew, >-----Original Message----- >From: [email protected] [mailto:[email protected]] On Behalf Of >andrzej zaborowski >Sent: Thursday, June 17, 2010 7:19 AM >To: [email protected] >Subject: Re: [PATCH 10/12] stk: Add parser for timing advance objects > >Hi, > >On 13 June 2010 11:43, Yang Gu <[email protected]> wrote: >> +enum stk_me_status { >> + STK_ME_STATUS_IDLE = 0x00, >> + STK_ME_STATUS_NOT_IDLE = 0x01 >> +}; >> + >> /* For data object that only has a byte array with undetermined length */ >> struct stk_common_byte_array { >> unsigned char *array; >> @@ -671,6 +676,18 @@ struct stk_timer_value { >> unsigned char second; >> }; >> >> +/* Defined in TS 31.111 Section 8.46 */ >> +struct stk_timing_advance { >> + ofono_bool_t has_value; >> + unsigned char status; > >Why change the status to char here? I think using an enum here is >nicer because it gives a hint to users about what values are expected >and the compiler can emit warnings if needed.
Agree and I will change this to enum. > >Regards >_______________________________________________ >ofono mailing list >[email protected] >http://lists.ofono.org/listinfo/ofono Regards, -Yang _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
