Hi Denis,
>-----Original Message----- >From: Denis Kenzior [mailto:[email protected]] >Sent: Thursday, June 17, 2010 6:48 AM >To: [email protected] >Cc: Gu, Yang >Subject: Re: [PATCH 05/12] Modify ussd parser > >Hi Yang, > >> * Original code doesn't call unpack_7bit(), which seems not correct. >> * An utility function is used to handle it, which supports 8-bit >> and ucs2 besides 7-bit character. >> * Status is assigned with correct value when error occurs > >Please drop this patch for now, the problem is that all AT modems do not >actually report USSD data as a PDU, instead they actually decode this into the >current character set of the modem (as set by +CSCS.) The spec really screwed >up on this one. > >This is one of the weirder parts of the spec, I don't think USSDs that are not >GSM 7 bit are even possible. At least not on the AT modems I've encountered. When it's GSM 7-bit, is it needed to call unpack_7bit() before calling convert_gsm_to_utf8()? The isimodem does so. Also the status doesn't have an initial value, so in some path of code status would have an uncertain value, which may cause problem when calling ofono_ussd_notify(). Maybe the situation is it's always GSM 7-bit, but the code shouldn't seem buggy. I will still include these changes in my new patches, feel free to comment them or even ignore them. > >Feel free to investigate this further. > >Regards, >-Denis _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
