Hi Yang, > >Again, please watch out for this. If your patch touches something in two > > or more directories of oFono, please send multiple patches. > > Thank you for applying the patches. But I have a question on this: Should > we keep the code compile-able after each patch? Due to this consideration, > I put those changes all in patch 2. This would sometimes be helpful when > we want to investigate a regression after a bunch of patches. If this is > not a requirement for this project, I will pay more attention on how to > split the patches reasonably.
Keeping the code compilable is always preferable. For instance, if you're adding a function to smsutil to use elsewhere, it is always preferable to have a commit with this function and then commit(s) using this function. However, there are cases when you're moving code around and breaking compile in transient commits is unavoidable. In that case I still prefer clean, logical patches. I will apply them all or not at all, so as long as the code compiles & works cleanly afterward, it is fine. Regards, -Denis > > >Regards, > >-Denis > > Regards, > -Yang > _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
