On Fri, 2010-07-02 at 13:43 -0700, Denis Kenzior wrote:
> Hi Inaky,
>
> Please remember not to go over 50 characters on your git commit
> description header and more than 72 characters on your git commit
> description body.
>
> > @@ -110,7 +110,9 @@ static gboolean parse_debug(const char *key, const char
> > *value,
> > static GOptionEntry options[] = {
> > { "debug", 'd', G_OPTION_FLAG_OPTIONAL_ARG,
> > G_OPTION_ARG_CALLBACK, parse_debug,
> > - "Specify debug options to enable", "DEBUG" },
> > + "Specify debug options to enable (see the "
> > + "man page for ofonod(8) for more information).",
>
> I still think mentioning the man page is a bit redundant.
>
> > + "DEBUG" },
> > { "nodetach", 'n', G_OPTION_FLAG_REVERSE,
> > G_OPTION_ARG_NONE, &option_detach,
> > "Don't run as daemon in background" },
>
> Regards,
> -Denis
Bah, hit enter too soon, sorry -- meant drop the .c code adding that,
but keep the additions to the man page. I'll redo that one.
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
