On Wed, 2010-07-07 at 16:04 -0700, Denis Kenzior wrote:
> Hi Inaky,
>
> <snip>
>
> ....
> > if (sms->txq) {
> > - g_queue_foreach(sms->txq, (GFunc)g_free, NULL);
> > + g_queue_foreach(sms->txq, tx_queue_entry_destroy_free, NULL);
> > g_queue_free(sms->txq);
> > sms->txq = NULL;
> > }
>
> Can we simply unify the two functions and simply call it
> tx_queue_entry_free? For symmetry renaming create_tx_queue_entry to
> tx_queue_entry_new would be nice.
Makes sense -- thought it cannot be done, but I realized
sms_msg_cancel() needs a _destroy_free(), not just a _destroy(), so that
settles that last one. Will do the _create() rename too.
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
