Hi, On 8 July 2010 21:28, Denis Kenzior <[email protected]> wrote: > On 07/06/2010 05:38 PM, Andrzej Zaborowski wrote: >> These are some patches I sent before reordered and refactored to >> skip stuff related to the Agent API, i.e. related to the UI. >> >> Andrzej Zaborowski (14): >> stk: Utilities for proactive command/envelope handling. >> mbmmodem: End session on *STKEND. >> stk: Handle the More Time proactive command as a nop. >> Add OFONO_ERROR_TYPE_SIM for negative SIM statuses. >> atmodem: Make sim operations return sim error codes. >> stk: Handle ENVELOPEs in a queue, retry on sim busy. >> Add __ofono_sms_submit for other atoms to submit SMs. >> stk: Handle the Send SMS proactive command. >> Add Dbus interface names for STK. >> stk: Handle the Set Up Idle Text proactive command. >> sktutil: Use the Mandatory flag in parse_dataobj. >> stkutil: Timer Value is conditional, not optional. >> stk: Handle the Timer Management proactive command. >> stk: Handle the Poll Interval proactive command. > > All patches in this series have been pushed upstream with some > refactoring afterwards. Please review and make sure I didn't screw > something up.
Thanks, just a small change to remove the seconds == 0 check for Set Poll Interval. Seconds can't be 0 or parsing would fail. The logic behind the original code was: Try to set the modem property to "seconds". If setting fails, then return the previous value (which is actually the nearest value we could accept). If getting previous value fails (function returns 0) then return 30 secs, the default value, which also happens to be the nearest we could accept. Best regards
0003-stk-Remove-a-unneeded-check.patch
Description: Binary data
_______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
