On Fri, 2010-07-23 at 16:06 -0700, Denis Kenzior wrote:
> Hi Inaky,
>
> > +
> > +/*
> > + * Destroy/release the contents of a 'struct tx_queue_entry'
> > + *
> > + * This releases resources allocated *inside* @entry and @entry
> > + * itself.
> > + */
> > +static void tx_queue_entry_destroy_free(gpointer _entry, gpointer unused)
>
> Can't this be simply tx_queue_entry_free? And feel free to take struct
> tx_queue_entry * here. Casting the destructor in g_foo_foreach is
> acceptable.
Renamed to tx_queue_entry_destroy() -- kept destroy vs free, as it has a
clearer meaning as to what the function does.
> > +{
> > + struct tx_queue_entry *entry = _entry;
> > +
> > + if (entry->destroy)
> > + entry->destroy(entry->data);
>
> An empty line after if/while/for blocks please. I will update the
> coding-style document with this rule shortly.
Done.
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono