On Tue, 2010-07-27 at 10:16 -0700, Denis Kenzior wrote: 
> Hi Inaky,
> 
> On 07/23/2010 04:00 PM, Inaky Perez-Gonzalez wrote:
> > From: Inaky Perez-Gonzalez <[email protected]>
> > 
> > This introduces the ability to cancel a pending SMS message,
> > accessible via an internal API and over a D-Bus wrapper.
> > 
> > Sending a note to the network to cancel an in-transit message is not
> > yet implemented.
> > 
> > Note the test case code requires follow up commits that propagate the
> > message's state changes over D-Bus.
> > ---
> >  src/sms.c                |   63 +++++++++++++++++
> >  src/smsutil.h            |   15 ++++
> >  test/test-sms-msg-cancel |  173 
> > ++++++++++++++++++++++++++++++++++++++++++++++
> 
> Multiple patches please.  One for each directory.
> ...
>

> You're ignoring about every part of the coding standard in this chunk...
> 
> ...

> And again ignoring the coding standard...

All feedback for this fixed, thanks.


_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to