Hi Denis,

>-----Original Message-----
>From: Denis Kenzior [mailto:[email protected]]
>Sent: Wednesday, August 25, 2010 11:07 PM
>To: [email protected]
>Cc: Gu, Yang
>Subject: Re: [PATCH] sim: Ensure to call sim_pin_check
>
>Hi Yang,
>
>> Your solution is better than mine, and might be Denis' intention of 
>> modification.
>Honestly, I ever thought about the change like your proposal (Actually it was 
>the same
>as ppessi's patch), but I had a concern on current code. Now we read EFli and 
>EFpl in
>parallel. Is it guaranteed the callback of EFli will be called before the 
>callback of EFpl?
>IMO, it can't always guarantee this. If I'm correct, your solution is just 
>half way to the
>final target. Maybe we need to work out a better one:)
>
>Please note that the ofono_sim_read functions do not work in parallel.
>All file operations are added to a queue and executed sequentially.
>Hence we can rely on a certain order here.

I see. So Jeevaka and Ppessi's patch is definitely better than mine.


Regards,
-Yang
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to