Hi Jeevaka,

On 2 September 2010 16:16,  <[email protected]> wrote:
>  The following patch "Added missing DCS handling in stkutil and stk"
> handles the missing dcs case as:
>
>  As per 3GPP TS 31.111 section 8.15 Text string structure requires dcs
> and text string to be sent. Current stkutil function and data structure
> is missing the dcs information.
>  In this patch, we handle the case where dcs will be a value other than
> -1, yesno and packed values are false. This text string structure is
> used in Terminal response of Get Inkey, Get Input and Send USSD.

There are two cases:
 * Get Inkey/Get Input, where the answer is actual text, in this case
the dcs can be determined automatically,

 * Send USSD where we're sending the "8.15 Text string" but the
contents don't actually have to contain a string, it may be any data
that the network sends us.  So to me it makes more sense to handle
this using a separate structure like you did in your original patch,
which contains len, dcs and contents.

Best regards
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to